lastSpeed setting only used when rememberSpeed is enabled #1348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when loading settings, lastSpeed will be set to 1 if rememberSpeed is not set, regardless of what is stored. This should fix issues where people not using 'remember speed' have their videos always starting at whatever is saved to lastSpeed, but lastSpeed never updates. See #1341, #1328, #1324, #1327
Note: I was not able to build the project to test it, I was having trouble getting it working on Windows. If someone can build it to confirm it works that would be great, or give me pointers on building it - I don't have a huge amount of experience with node. Below is the issue it's throwing:
I'm on windows 11 - like I said I'll keep looking into it to see if I can get a build working. Also tried WSL, that had different issues.