Added correlation-types to DR2 Lya BAO default config - #43
Merged
Conversation
Collaborator
|
@andreufont good catch! Yes, this looks like the right spot to add this argument. I'll merge this pull request, and then modify the instructions for DR2 BAO to use this file on GitHub, or to add the argument is using the files on NERSC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@m-herbold - I added the extra variable needed to the DR2 Lya BAO defaults file, since I think it was still missing.
Could you check that this is indeed how this is supposed to be implemented? I copied it from the FS equivalent.
By the way, the "reproduce dr2" instructions suggest you can copy these files from NERSC, but unfortunately those files are no longer valid because they don't have this variable set.
I think this is ok, since the files at NERSC should be considered read-only, and reflect what was actually used at the time. I would just modify the instructions to point to files in this repo, that we can update if needed.