LyaCoLoRe version used for DESI DR2 FS analysis. - #103
Draft
mruizherrerab wants to merge 2 commits into
Draft
Conversation
andreufont
reviewed
May 13, 2026
|
|
||
| # This is an empirical 2LPT threshold for objects with b=2 coming from CoLoRe-2LPT snapshot version. | ||
| def lpt_threshold(z): | ||
| a=5.33080934 |
Collaborator
There was a problem hiding this comment.
How did you obtain this? It is probably a function of cosmology, right? Do you expect this to be also a function of box resolution?
andreufont
reviewed
May 13, 2026
Collaborator
There was a problem hiding this comment.
It would be great if @Laura-Casas tried to run LyaCoLoRe on a 2LPT box herself using the instructions, to validate them.
@mruizherrerab - it would be also great if you could add instructions about how to setup a future suite of sims if we changed the input cosmology or the box size / resolution. It is probably not easy to have automated scripts, I believe you had to do several steps by hand, right? But at least document well the steps to create the files that you added here (like the cell fraction for DLAs).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes: