Skip to content

Conversation

@daveroga
Copy link
Contributor

@daveroga daveroga commented Feb 6, 2026

  • Calculation for groupID should not be based on requestIds but random bytes
  • Check that groupID fits in field size because it's used in circuits

@coveralls
Copy link

coveralls commented Feb 6, 2026

Pull Request Test Coverage Report for Build 21906805977

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 94.036%

Totals Coverage Status
Change from base Build 21756634338: 0.05%
Covered Lines: 3890
Relevant Lines: 4032

💛 - Coveralls

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates how groupID is generated/validated so it is no longer derived from request IDs, and ensures groupID fits within the zk-circuit field size constraint.

Changes:

  • Switched test groupID generation to use random bytes (masked to field size) instead of hashing request IDs.
  • Updated VerifierLib to validate groupID by enforcing it fits in the field (mask check) rather than recomputing it from concatenated request IDs.
  • Expanded integration test coverage with new revert cases for invalid group IDs and single-request groups.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test/verifier/verifier.test.ts Updates unit tests to use the new calculateGroupID() API (no requestId inputs).
test/utils/id-calculation-utils.ts Changes calculateGroupID to generate a masked random value rather than hashing request IDs.
test/integration-tests/integration-verifier.test.ts Updates integration tests for new groupID generation and adds new revert test cases.
contracts/lib/VerifierLib.sol Renames userID check helper and changes groupID validity check to field-size enforcement.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@daveroga daveroga merged commit 8db4404 into master Feb 12, 2026
5 checks passed
@daveroga daveroga deleted the PID-3650-remove-group-id-calculation-check branch February 12, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants