[Patch] Customization archive validator#2239
Open
Knickkennedy wants to merge 3 commits intoibm-mas:masterfrom
Open
[Patch] Customization archive validator#2239Knickkennedy wants to merge 3 commits intoibm-mas:masterfrom
Knickkennedy wants to merge 3 commits intoibm-mas:masterfrom
Conversation
Signed-off-by: Knicholas Kennedy <knicholas.kennedy@gmail.com>
…e validator to the prompt for string in manageSettings.py Signed-off-by: Knicholas Kennedy <knicholas.kennedy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2063
Was pretty straightforward, I added a validator to validators.py that simply checks against the error code using that regex to ensure it matches 1:1 and then added the validator to manageSettings.py. I once again do not know how the MAS team handles releases or merges, so I'm simply doing my best with what I have. I've validated that the regex works when I build locally.