Skip to content

[Patch] added 9.1.x to cognos install manageSettingsCP4D#2238

Open
Knickkennedy wants to merge 2 commits into
ibm-mas:masterfrom
Knickkennedy:9.1.x-add
Open

[Patch] added 9.1.x to cognos install manageSettingsCP4D#2238
Knickkennedy wants to merge 2 commits into
ibm-mas:masterfrom
Knickkennedy:9.1.x-add

Conversation

@Knickkennedy
Copy link
Copy Markdown

This fixes #2217 by simply adding 9.1.x to the list of supported versions in python/src/install/manageSettings.py. A more robust fit would be something like

def manageSettingsCP4D(self) -> None:
    from mas.devops.utils import isVersionEqualOrAfter
    channel = self.getParam("mas_app_channel_manage")
    if isVersionEqualOrAfter('8.7.0', channel) and self.showAdvancedOptions:

but I am not a regular contributor to the CLI and don't want to presume an architecture change. I'm also happy to make that change instead if we want to test and validate. I just was not sure what the intent around the hard-coded list would be moving forward.

Signed-off-by: Knicholas Kennedy <knicholas.kennedy@gmail.com>
@Knickkennedy Knickkennedy requested a review from a team as a code owner May 2, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Advanced install option skips option to install CP4d

1 participant