[Patch] added 9.1.x to cognos install manageSettingsCP4D#2238
Open
Knickkennedy wants to merge 2 commits into
Open
[Patch] added 9.1.x to cognos install manageSettingsCP4D#2238Knickkennedy wants to merge 2 commits into
Knickkennedy wants to merge 2 commits into
Conversation
Signed-off-by: Knicholas Kennedy <knicholas.kennedy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2217 by simply adding 9.1.x to the list of supported versions in python/src/install/manageSettings.py. A more robust fit would be something like
but I am not a regular contributor to the CLI and don't want to presume an architecture change. I'm also happy to make that change instead if we want to test and validate. I just was not sure what the intent around the hard-coded list would be moving forward.