[patch] Add validation for customization archive name in interactive installation#2230
Open
PalVala wants to merge 5 commits into
Open
[patch] Add validation for customization archive name in interactive installation#2230PalVala wants to merge 5 commits into
PalVala wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installation fails when customization archive names contain spaces or invalid characters, causing this Kubernetes API error:
Invalid value: "Custom Archive": spec.settings.customizationList[0].customizationArchiveName
in body should match '^[0-9a-zA-Z][0-9a-zA-Z-_.]+$'
Solution
Changes:
User Experience
Invalid input is rejected immediately with a clear error message and automatic re-prompt:
Customization archive name: CustomMas
Invalid format. Must start with alphanumeric character and contain only
alphanumeric characters, hyphens (-), underscores (), and periods (.). No spaces allowed.
Customization archive name: CustomMas
Files Changed:
Screenshots