[patch] Fix MinIO IPv4 binding and AI Service MinIO secret#2213
Open
belfortmaycon wants to merge 3 commits into
Open
[patch] Fix MinIO IPv4 binding and AI Service MinIO secret#2213belfortmaycon wants to merge 3 commits into
belfortmaycon wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes two MinIO-specific issues in the AI Service installation flow.
[::]:9090and[::]:9000), which made the console and API unreachable on IPv4 clusters even whenENABLE_IPV6=false.km-s3-secretalways populatedAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEY. WhenINSTALL_MINIO=true, those keys must still exist but be empty; populating them breaks the service for the MinIO-backed configuration.Impact:
ENABLE_IPV6=falsenow renders MinIO listeners on0.0.0.0:9090and0.0.0.0:9000.ENABLE_IPV6=truekeeps the IPv6 listener values unchanged.INSTALL_MINIO=true,km-s3-secretnow renders emptyAWS_*values while keeping theS3_*values populated.AWS_*andS3_*credential values.Test Results
ibm/mas_devops/roles/minio/templates/minio/minio-deployment.yml.j2withenable_ipv6=falserendered0.0.0.0:9090and0.0.0.0:9000.enable_ipv6=truerendered[::]:9090and[::]:9000.ibm/mas_devops/roles/aiservice/templates/aiservice/s3-secret.yml.j2withinstall_minio=truerendered emptyAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYand preserved populatedS3_*values.install_minio=falserendered populatedAWS_*andS3_*values.