[Behat] IBX-10943: Added coverage for wrong old pass validation#1843
Open
[Behat] IBX-10943: Added coverage for wrong old pass validation#1843
Conversation
juskora
changed the title
juskora
force-pushed
the
IBX-10943-behat-old-password-verification
branch
from
1e0e114 to
ae57cd0
Compare
|
juskora
requested review from
a team,
KamilSznajdrowicz,
barbaragr,
katarzynazawada,
micszo,
pawlakadrian and
tomaszszopinski
This was referenced Mar 5, 2026
Contributor
tomaszszopinski
left a comment
tomaszszopinski
left a comment
There was a problem hiding this comment.
👍 (just some nitpicks from me).
| When I go to user settings | ||
| And I switch to "Account settings" tab in User settings | ||
| And I click on the change password button | ||
| And I change password from "Passw0rd-42" to "Passw0rd-44" |
Contributor
There was a problem hiding this comment.
Suggested change
| And I change password from "Passw0rd-42" to "Passw0rd-44" | |
| When I change password from "Passw0rd-42" to "Passw0rd-44" |
| And I click on the change password button | ||
| And I change password from "Passw0rd-42" to "Passw0rd-44" | ||
| And I perform the "Save and close" action | ||
| Then "Current password" field validates with error message "Current password is incorrect." No newline at end of file |
Contributor
There was a problem hiding this comment.
Reminder to add newline
| */ | ||
| public function iValidateOldPassword(string $expectedMessage): void | ||
| { | ||
| $this->changePasswordPage->verifyValidationMessage($expectedMessage); |
Contributor
There was a problem hiding this comment.
Maybe:
Suggested change
| $this->changePasswordPage->verifyValidationMessage($expectedMessage); | |
| $this->changePasswordPage->verifyPasswordValidationMessage($expectedMessage); |
|
|
||
| public function verifyValidationMessage(string $expectedMessage): void | ||
| { | ||
| $this->getHTMLPage() |
Contributor
There was a problem hiding this comment.
Suggested change
| $this->getHTMLPage() | |
| $this->getHTMLPage()->setTimeout(3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: