Fix bugs, UB, and linker errors across codebase - #67
Merged
Conversation
- Fix duplicate symbol linker errors by marking `numberTextMap` and `getVersionFromDateTime` as `inline` - Fix `std::toupper` UB on negative chars in GPU brand detection - Fix `bufferSize` reuse bug in `obtenerCurrent` causing silent registry read failures - Fix `getOriginalValue` path parsing (validate prefix, handle empty/short paths, avoid UB) - Fix `anySelected` not resetting between AdvanceMode sessions - Fix `enableBtn` state leaking across loop iterations - Fix `lineaEncabezado` padding arithmetic with unsigned size_t - Fix resource ID collision (IDR_MIDI_FILE 101→102) - Fix `pause` hanging CI in PostBuildEvent bat script - Extract `ClaveDeRegistroTemporal` into shared `registry_fixture.h` - Add tests for registry edge cases and non-ASCII GPU names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Include relevant motivation and context.
numberTextMapandgetVersionFromDateTimeasinlinestd::toupperUB on negative chars in GPU brand detectionbufferSizereuse bug inobtenerCurrentcausing silent registry read failuresgetOriginalValuepath parsing (validate prefix, handle empty/short paths, avoid UB)anySelectednot resetting between AdvanceMode sessionsenableBtnstate leaking across loop iterationslineaEncabezadopadding arithmetic with unsigned size_tpausehanging CI in PostBuildEvent bat scriptClaveDeRegistroTemporalinto sharedregistry_fixture.h