Skip to content

feat: add nameless identity function#415

Open
iamgio wants to merge 2 commits intomainfrom
03-22-feat_add_nameless_identity_function
Open

feat: add nameless identity function#415
iamgio wants to merge 2 commits intomainfrom
03-22-feat_add_nameless_identity_function

Conversation

@iamgio
Copy link
Copy Markdown
Owner

@iamgio iamgio commented Mar 23, 2026

This PR adds:

  • support for unnamed function calls.
  • an identity function with an empty name.

The identity function allows for function call chaining from a static value: this call is now valid: .{10}::multiply {5}


Open with Devin

Copy link
Copy Markdown
Owner Author

iamgio commented Mar 23, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iamgio iamgio marked this pull request as ready for review March 23, 2026 04:40
@iamgio iamgio force-pushed the 03-22-feat_add_nameless_identity_function branch from 794be92 to 6d799bb Compare March 23, 2026 04:41
@iamgio iamgio added the enhancement New feature or request label Mar 23, 2026 — with Graphite App
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review

Comment on lines +455 to +456
@Name("")
fun identity(value: DynamicValue): DynamicValue = value
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Missing CHANGELOG.md update for new nameless/identity function call feature

The CLAUDE.md rule file states: "When making changes to the compiler or other modules, features or changes, make sure to also update the documentation accordingly, along with CHANGELOG.md." This PR introduces a new user-facing feature (nameless/identity function calls via .{value} syntax) with changes to the lexer, parser, grammar, and stdlib, but does not include a CHANGELOG.md update documenting this addition.

Prompt for agents
Add an entry to CHANGELOG.md documenting the new nameless/identity function call feature. Following the Keep a Changelog format used in the project, add an entry under the appropriate version's Added section describing the new .{value} syntax for nameless (identity) function calls, including a link to the relevant documentation at https://quarkdown.com/wiki/syntax-of-a-function-call#nameless-calls.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment thread quarkdown-lsp/src/test/kotlin/com/quarkdown/lsp/FunctionCompletionSupplierTest.kt Outdated
@iamgio iamgio force-pushed the 03-22-feat_add_nameless_identity_function branch from 6d799bb to 54d4d20 Compare March 23, 2026 04:55
@iamgio iamgio force-pushed the 03-22-feat_add_nameless_identity_function branch from 54d4d20 to dfdade6 Compare March 23, 2026 04:56
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 5 additional findings in Devin Review.

Open in Devin Review

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 CHANGELOG.md not updated per CLAUDE.md guidelines

CLAUDE.md states: "When making changes to the compiler or other modules, features or changes, make sure to also update the documentation accordingly, along with CHANGELOG.md." This PR adds a new language feature (nameless identity function calls) but does not include a CHANGELOG.md update. The docs/syntax-of-a-function-call.qd file was updated, which partially addresses the documentation requirement. This is a process guideline rather than a code correctness issue.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant