Add ActionGroupSetupNotFoundException and DuplicateActionOnDeviceException #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pSetupNotFoundException
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces two new Overkiz-specific exceptions and updates response parsing so the client can raise more precise errors when the API returns known “duplicate action” and “missing action group setup” failures.
Changes:
- Added
DuplicateActionOnDeviceExceptionandActionGroupSetupNotFoundException. - Updated
check_responseto detect two additional API error-message patterns and raise the new exceptions. - Normalized several inline error-message examples to consistent JSON-style formatting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
pyoverkiz/exceptions.py |
Adds two new custom exception classes for specific API error cases. |
pyoverkiz/client.py |
Imports and raises the new exceptions based on matched API error messages; updates inline comment formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…nd ActionGroupSetupNotFoundException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances error handling in the Overkiz client by introducing two new custom exceptions and updating the response checking logic to catch and raise these exceptions based on specific API error messages. Additionally, it refines and clarifies the error message comments for better maintainability.
Error handling improvements:
DuplicateActionOnDeviceExceptionandActionGroupSetupNotFoundException, topyoverkiz/exceptions.pyfor handling specific API error cases.pyoverkiz/client.pyto import the new exceptions.check_responsefunction inpyoverkiz/client.pyto detect error messages indicating a duplicate action on a device or a missing action group setup, and to raise the corresponding new exceptions.Documentation and code clarity:
check_responseto use consistent JSON-style formatting for API error messages, improving readability and maintainability. [1] [2] [3]Fixes #1918