refactor(tests): use explicit assertions following Python idioms #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `is None` / `is not None` for explicit None checks (PEP 8) - Use `pytest.raises(TypeError, lambda: expr)` for exception tests - Keep `assert collection` for empty/non-empty checks (Pythonic)
tetienne
force-pushed
the
refactor/pythonic-test-assertions
branch
from
1c9af04 to
25f1d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the test suite with Python best practices:
is None/is not Nonefor explicit None checks (PEP 8)pytest.raises()pattern for exception testsper-file-ignoresfor S101 in tests, removing redundant inline# noqacommentsos.pathwithpathlib.Pathin test_client.pyMockResponse,client,local_client) totests/conftest.pyTest Plan