Skip to content

Fixes to enable running tests locally #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
borislaviv wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes to enable running tests locally #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ ADD ./idp-public-cert.pem idp-public-cert.pem
ADD ./idp-private-key.pem idp-private-key.pem
ADD ./public public

ENTRYPOINT [ "node", "app.js", "--acs", "http://localhost:8080/saml2/acs", "--aud", "http://localhost:8080/", "--host", "0.0.0.0" ]
ENTRYPOINT [ "node", "app.js", "--acs", "http://localhost:8080/saml2/acs", "--aud", "http://devops-testing-master01.int.hyperscience.com/", "--host", "0.0.0.0" ]

@georgipopovhs georgipopovhs Mar 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the docs at https://hyperscience.atlassian.net/wiki/spaces/TECH/pages/2785247427/Local+development+with+SAML
the idea is to be able to run the app locally with this Dockerfile, as opposed to running the tests.

Personally, I don't have a huge preference to one or the other (last time I believe I needed to run both) to be the default. If you decide to keep this change, please update the docs in the wiki as well.

It'd be ideal if we somehow make it easy to run both local tests & local app & CI tests, though not sure how :)

@JPDSousa JPDSousa Mar 11, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as we have a consistent aud/Entity ID, it should be fine. Reminder that the entity ID is just a string that the service provider and the identity provider use to make sure they're talking to each other, which usually defaults to the service provider URL.

1 change: 0 additions & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
services:
saml-idp:
build: .
network_mode: "host"
ports:
- "7000:7000"
Loading