fix: preserve sign in truncate_float (negatives silently became 0.0)#194
Open
PrazwalR wants to merge 1 commit into
Open
fix: preserve sign in truncate_float (negatives silently became 0.0)#194PrazwalR wants to merge 1 commit into
PrazwalR wants to merge 1 commit into
Conversation
truncate_float cast (float * pow10) to u64, which saturates any negative input to 0. As a public API used for price/size math in a trading SDK, this silently corrupted negative values (e.g. -123.456 -> 0.0). Compute truncation on the magnitude and reapply the sign so negatives round symmetrically to positives; the positive path is unchanged. Add regression tests: concrete negatives, positive-path parity, round_up on both signs, zero/-0.0 edges, NaN propagation, and an antisymmetry property test (truncate(-x) == -truncate(x)) over 36k cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
truncate_float(public API,src/helpers.rs) casts(float * pow10)tou64. In Rust, casting a negativef64to an unsigned int saturates to 0,so every negative input is silently destroyed: