This repository was archived by the owner on Feb 1, 2024. It is now read-only.
Fix bug in commit_store get_batch_by_transaction - #176
Merged
Conversation
suchapalaver
requested review from
agunde406,
cianx,
dcmiddle,
isabeltomb,
jsmitchell,
peterschwarz,
rberg2,
rbuysse and
vaporos
as code owners
October 10, 2023 17:58
Signed-off-by: Joseph Livesey <jlivesey@gmail.com>
Signed-off-by: Joseph Livesey <jlivesey@gmail.com>
suchapalaver
force-pushed
the
fix/fix-bug-in-commit-store-get-batch-by-transaction-method
branch
from
October 10, 2023 18:01
992ccad to
10b4c5f
Compare
agunde406
approved these changes
Oct 10, 2023
vaporos
approved these changes
Oct 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
sawtooth_validator::journal::commit_store::CommitStore'sget_batch_by_transactionmethod, which heretofore returned the first batch that does not contain the providedtransaction_idargument without any error.Original work
See also: hyperledger/sawtooth-core PR#2458
Signed-off-by: Joseph Livesey jlivesey@gmail.com