fix: update stale links, fix code bugs, and rebrand Hyle to Hyli#50
Open
giwaov wants to merge 1 commit intohyli-org:mainfrom
Open
fix: update stale links, fix code bugs, and rebrand Hyle to Hyli#50giwaov wants to merge 1 commit intohyli-org:mainfrom
giwaov wants to merge 1 commit intohyli-org:mainfrom
Conversation
- Update all docs.hyle.eu links to docs.hyli.org
- Update all hyle-org/hyle git dependency URLs to hyli-org/hyli
- Update all Hyle-org GitHub org references to hyli-org
- Fix broken simple_erc20 branch references to main
- Fix format string bug in simple-identity (literal {} instead of format!)
- Fix wrong error message values in ticket-app (was showing contract name and recipient instead of price and amount)
- Fix stale "hyllar state" error message in simple-token
- Fix copy-paste comments (Amm -> TicketApp, Simple Token -> Check Secret)
- Fix typos: contrat -> contract, Weither -> Whether
- Rebrand Hyle/Hylé -> Hyli across all READMEs
bff06d3 to
4864711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes stale references from the Hyle -> Hyli rebrand, corrects actual code bugs, and fixes typos across all example contracts.
Stale links & references (21 files)
docs.hyle.eulinks todocs.hyli.org(7 occurrences across READMEs)hyle-org/hylegit dependency URLs tohyli-org/hyli(8 Cargo.toml files)Hyle-orgGitHub org references tohyli-org(3 README links)simple_erc20branch references tomain(2 links)Code bugs fixed
Ok("Successfully registered identity for account: {}".to_string())used a literal{}instead offormat!()— the account name was never interpolatedself.ticket_price.0(token name) and&recipient(address) instead of the expected price (self.ticket_price.1) and actualamountTypos & copy-paste fixes
contrat→contract(simple-identity)Weither→Whether(check-secret-noir)Amm contract→TicketApp contract(ticket-app comment)Simple Token Contract implementation in Noir→Check Secret Contract implementation in Noir(check-secret-noir)Test plan