Add fake port option#30
Open
Protryon wants to merge 4 commits into
Open
Conversation
Contributor
|
Apologies as you might have heard we just got acquired by HuggingFace. Things have been hectic for a while, but now I have bandwidth to review this. Thanks for the patience! |
Contributor
|
How about adding a new, optional Something like this: I think the ability to advertise a different port from the actual listening port is very useful, especially when dealing with Windows clients. |
Contributor
|
Can we maybe split this into 2 PRs? This looks like it has 2 pieces. One which implements NLM4 protocol (thanks!), and another for a port number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a fake port option for wonky firewall shenanigans.