fix(ci): workflow_dispatch boolean input for SDK generation#755
Merged
fix(ci): workflow_dispatch boolean input for SDK generation#755
Conversation
…e input workflow_dispatch inputs are strings; passing force as string "false" caused 'Unexpected value "false"' when calling sdk-generate-one. Convert with force == 'true' so the reusable workflow receives a proper boolean. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the manual per-language SDK generation GitHub workflows to pass a proper boolean value for the force input into the reusable sdk-generate-one.yml workflow (which declares force as a boolean).
Changes:
- Convert
forcefrom theworkflow_dispatchevent payload into a boolean expression (== 'true') when passing to the reusable workflow. - Apply the same
forcehandling consistently across Go, Python, and TypeScript SDK generation workflows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/sdk_generation_outpost_ts.yaml |
Ensures force is passed as a boolean when triggering TS SDK generation. |
.github/workflows/sdk_generation_outpost_python.yaml |
Ensures force is passed as a boolean when triggering Python SDK generation. |
.github/workflows/sdk_generation_outpost_go.yaml |
Ensures force is passed as a boolean when triggering Go SDK generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+19
to
20
| force: ${{ github.event.inputs.force == 'true' }} | ||
| set_version: ${{ github.event.inputs.set_version }} |
Comment on lines
+19
to
20
| force: ${{ github.event.inputs.force == 'true' }} | ||
| set_version: ${{ github.event.inputs.set_version }} |
Comment on lines
+19
to
20
| force: ${{ github.event.inputs.force == 'true' }} | ||
| set_version: ${{ github.event.inputs.set_version }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Manual SDK generation workflows (Generate OUTPOST-GO, OUTPOST-TS, OUTPOST-PYTHON) fail with:
when run with the default Force checkbox unchecked.
workflow_dispatchinputs are always strings ("true"/"false"). Passingforce: ${{ github.event.inputs.force }}sends the string"false"into the reusable workflow, which expects a boolean and rejects it.Fix
Convert the input to a boolean before passing to
sdk-generate-one.yml:Applied in all three manual workflows:
.github/workflows/sdk_generation_outpost_go.yaml.github/workflows/sdk_generation_outpost_ts.yaml.github/workflows/sdk_generation_outpost_python.yamlTesting
Re-run Generate OUTPOST-GO (or trigger manually) with Force unchecked; the workflow should start successfully.
Made with Cursor