Segfault on deletion of an item residing in the container stack#2624
Merged
hoffstadt merged 1 commit intohoffstadt:masterfrom Apr 6, 2026
Merged
Conversation
…er causes a segfault.
hoffstadt
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Segfault on deletion of an item residing in the container stack
assignees: @hoffstadt
Description:
The container stack stores raw
mvAppItempointers, which makes item deletion potentially unsafe. Of course nobody in their right mind would delete an item being in the container stack (because it's unclear what's expected of the stack then), but just in case someone does, DPG must handle it gracefully.This PR changes the container stack to use
shared_ptrand therefore prevents the segfault. If the item being deleted is still on the container stack, it will be destroyed once it's popped from the stack.Concerning Areas:
None.