PO-2306 Add report summary screen - #2866
Closed
TimDanielsCQI wants to merge 17 commits into
Closed
Conversation
louisbriggs
requested changes
Jul 20, 2026
| @@ -0,0 +1,16 @@ | |||
| import { FINES_REPORTS_REPORT_SUMMARY_STATUSES } from './fines-reports-report-summary-statuses.constant'; | |||
|
|
|||
| export const FINES_REPORTS_REPORT_SUMMARY_STATUS_DISPLAY = { | |||
Contributor
There was a problem hiding this comment.
Split each const into it's own file.
| root: 'reports', | ||
| children: { | ||
| summaryList: 'summary-list', | ||
| reportSummary: 'summary/:instanceId', |
Contributor
There was a problem hiding this comment.
Can the instanceId param be removed from this const and added to the path in the router file e.g.
path:
${FINES_REPORTS_ROUTING_PATHS.children.reportSummary}/:instanceId
This would make it consistent with other paths.
| }, | ||
| }, | ||
| { | ||
| path: FINES_REPORTS_ROUTING_PATHS.children.reportSummary, |
Contributor
There was a problem hiding this comment.
The dynamic param instanceId can be added to the path here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
See PROJ-XXXXXX
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist