Default scheduler and hearing-lookup flags to disabled - #210
Merged
Conversation
CP_CDK_SCHEDULER_INTRADAY_DISCOVERY_ENABLED, CP_CDK_SCHEDULER_NIGHTLY_DISCOVERY_ENABLED, and CP_CDK_HEARING_IS_HEARING_FOR_CASES_ENABLED defaulted to true on main. The disable-by- default fix (#208) had only landed on release_2623, which was never merged into develop before develop was merged to main (#209), so main and develop both still shipped with the flags on. Restores the false defaults so the features must be explicitly enabled per environment. Also adds a permanent low-priority WireMock stub for /hearing-cases-for-day (empty hearingCases response) alongside the existing pattern for /hearings. Background scheduler cron ticks in the docker-compose integration stack were hitting this endpoint before NightlyDiscoverySchedulerLiveTest registered its own dynamic stub, causing an intermittent 404 ("closest stub not matching") in CI; the fallback stub ensures a match is always available. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
natrajmolala
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falsedefaults forCP_CDK_SCHEDULER_INTRADAY_DISCOVERY_ENABLED,CP_CDK_SCHEDULER_NIGHTLY_DISCOVERY_ENABLED, andCP_CDK_HEARING_IS_HEARING_FOR_CASES_ENABLED, which had reverted totrueonmain.release_2623.developwas merged intomainseparately (Merge from develop to main for release2623 #209) without ever incorporatingrelease_2623's fix, somain(anddevelop) kept shipping with these flags on by default./hearing-cases-for-day(emptyhearingCasesresponse), matching the existing pattern used for/hearings. Fixes an intermittent 404 ("closest stub not matching") in CI integration tests: background scheduler cron ticks in the docker-compose stack were hitting this endpoint beforeNightlyDiscoverySchedulerLiveTestregistered its own dynamic stub.Test plan
gradle integration --tests "*NightlyDiscoverySchedulerLiveTest*" --tests "*IntradayDiscoverySchedulerLiveTest*"— all 6 tests pass (3 per class, 0 failures/errors) against the docker-compose stack.gradle clean build/ CI pipeline run.developso it doesn't regress on the next release merge tomain.🤖 Generated with Claude Code