feat: carry blackboard reads/writes in the protocol crate (lockstep) - #37
Merged
Conversation
Lockstep half of the daemon's goal-blackboard slice 1. CONTRIBUTING requires
this crate to move with the daemon's packages/protocol.
- `reads` / `writes` on CollaborationRole: the artifact kinds a role may read
and write on the goal blackboard (`spec`, `research`, `adr`, `task-list`,
`diff`, `findings`, or `extra/<key>`).
`None` means "use the daemon's default profile for this role name", which is
NOT the same as an empty list ("read/write nothing") — the daemon distinguishes
them, so these stay Option<Vec<String>> rather than defaulting to an empty vec
here. Collapsing the two would silently strip every default profile.
Kept as plain strings, not an enum: the artifact vocabulary has a fixed core
plus an `extra/<key>` escape hatch, so an enum here would reject a valid kind a
newer daemon accepts.
The wire_format review role now carries populated lists rather than None, so
the recursive camelCase walker actually visits them and a future rename of
either field fails the wire test.
cargo build + clippy + test green: 354 tests; clippy warnings unchanged
(7 before, 7 after on codeoid-protocol, verified by stashing).
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
akashjavelin
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockstep half of highflame-ai/codeoid#260 (goal blackboard, slice 1). CONTRIBUTING requires this crate to move with the daemon's
packages/protocol/.What changed
reads/writesonCollaborationRole— the artifact kinds a role may read and write on the goal blackboard (spec,research,adr,task-list,diff,findings, orextra/<key>).Two choices worth noting:
Option<Vec<String>>, not defaulted to an empty vec.Nonemeans "use the daemon's default profile for this role name", which is not the same as an empty list ("read/write nothing"). The daemon distinguishes them; collapsing the two here would silently strip every default profile.extra/<key>escape hatch, so an enum would reject a valid kind that a newer daemon accepts.Verification
cargo build,cargo clippy --all-targets,cargo test --workspacegreen — 354 tests.codeoid-protocol(verified by stashing the change, not by eyeballing).wire_formatreview role now carries populated lists rather thanNone, so the recursive camelCase walker actually visits them and a future rename of either field fails the wire test.Follow-up (not here)
Still nothing renders any of this. Combined with #36, the TUI now receives role, ordinal, write authority, and artifact scoping for every collaboration child and displays none of it — a fleet still looks like N unrelated sessions. Worth a dedicated PR against the session list and title once the daemon side settles.
🤖 Generated with Claude Code