HHH-19993 Introduce UserTypeCreationContext and AnnotationBasedUserType #11445
+377
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gavinking Please review. |
gavinking
requested changes
Dec 16, 2025
hibernate-core/src/main/java/org/hibernate/usertype/AnnotationBasedUserType.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/boot/model/internal/BasicValueBinder.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/mapping/SimpleValue.java
Outdated
Show resolved
Hide resolved
quaff
changed the title
quaff
force-pushed
the
HHH-19993
branch
3 times, most recently
from
f0fbaa4 to
5024e01
Compare
gavinking
reviewed
Dec 16, 2025
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
quaff
commented
Dec 17, 2025
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
quaff
force-pushed
the
HHH-19993
branch
2 times, most recently
from
9678cbb to
023c027
Compare
gavinking
reviewed
Dec 19, 2025
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Dec 19, 2025
hibernate-core/src/main/java/org/hibernate/mapping/MappingHelper.java
Outdated
Show resolved
Hide resolved
gavinking
reviewed
Dec 19, 2025
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
gavinking
requested changes
Dec 22, 2025
hibernate-core/src/main/java/org/hibernate/usertype/UserType.java
Outdated
Show resolved
Hide resolved
quaff
changed the title
gavinking
requested changes
Dec 22, 2025
Member
gavinking
left a comment
gavinking
left a comment
There was a problem hiding this comment.
The search for constructors is sort of in the wrong order. It should look first for a constructor which takes both annotation and context, and then it should look for a constructor which accepts one or the other.
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
hibernate-core/src/main/java/org/hibernate/mapping/BasicValue.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yanming Zhou <[email protected]>
Contributor
Author
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19993