Add Alpine 3.23 support #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR attempts to add Alpine 3.23 support to the Docker build checker. The change consolidates four separate Alpine version regex patterns (3.19-3.22) into a single regex pattern that matches versions 3.19-3.23. However, this consolidation introduces a critical bug that will break the build system.
Key Issues
- The consolidated regex will only match one Alpine version instead of all five versions, breaking builds for Alpine 3.19-3.22 and only building one version instead of five
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ericmj Can you take a look, please? |
Member
|
Please remove 3.19 since it's not supported according to https://hub.docker.com/_/alpine. We can merge this after the backlog of OTP 28.3 images have been pushed. |
Closed
Contributor
Author
|
@ericmj done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #228