Feature: entity computed property#69
Draft
VictorTBX wants to merge 3 commits intoherbsjs:masterfrom
Draft
Conversation
added 2 commits
December 27, 2022 21:46
…them when properties are set feature herbsjs#68
Member
|
great PR! from #68 (comment)
with no tests I think it's hard to affirm it's only two problems... In order to improve this PR, even for a POC, tests are mandatory to understand the proposal and the implementation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#68
This is still a draft, I'd like of understand if I'm on the right path before continuing.
Proposed Changes
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance