Suggestion for fixing the exclude nodes filter#130
Open
dgem wants to merge 3 commits intohellofresh:masterfrom
Open
Suggestion for fixing the exclude nodes filter#130dgem wants to merge 3 commits intohellofresh:masterfrom
dgem wants to merge 3 commits intohellofresh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
As per comment from @js-timbirkett, the filtering of nodes via
EXCLUDE_NODE_LABEL_KEYSdoesn't seem to work.As a suggestion, I've modified
get_k8s_nodes()to returnnodes, excluded_nodes, then modified the callers of it, etc.Also fixes: #94
Let me know what you think,
Kind regards
Dan