Fix: show outdated comments instead of hiding them#24
Merged
Conversation
When a document is edited after comments are placed, character offsets shift and excerpt text may vanish. Previously these threads silently disappeared from the document view while the sidebar still showed the correct count. Now the server computes outdated status (hash mismatch + excerpt not found) and the frontend renders unresolvable threads in a visible "Outdated Comments" section at the bottom of the document with their original context preserved. Also removes the dead sync/publish code (ReviewSyncer interface, handlers, UI buttons) which were no-op stubs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReviewSyncerinterface, handlers, UI buttons)Test plan
draft reviewon a repo with existing commentsgo build ./...andgo test ./internal/review/...pass🤖 Generated with Claude Code