[WIP] Fixing issue #618 add\remove mk\lobyist submit buttons are now disabled by default on the committee meeting page

[farchy]

Relating issues

• Resolves add/remove Mk/lobbyist button to committee meeting should be disabled if field is empty #618

Change list

• Added a default 'disabled' state on the committee meeting mk and lobyist addition / removal
• Added a behavior of disabling a submit button whenever the data is not a valid name (similar to the one in meeting bill addition)

Further work

• Still need to (maybe) only allow removing members actually in the meeting

[alonisser]

@farchy Thanks! I looked at the code and missed where the actual validation takes place? what is a "valid" name.
Also, I do think that removing only existing mk is better, But not sure that can be easily achieved from front end only

[farchy]

@alonisser You are right, the usage of the word validation is misleading, what I mean is the submit is enabled on the actual selection from the autocomplete box, and disables again on any manual change.

There is a bug I just noticed, when writing a valid name without selecting from the drop-down, this happens in both the addition\removal inputs and the bill addition box.

Another bug I saw when implementing (but didn't want to mix is with this fix) is of the tooltip and input box while selecting the mk\lobyist as shown here:

I'll open another issue on this later on.

[alonisser]

Ok, so before we merge, please fix the first bug. and for the second, did
it exist before or is it a regression? I would be glad if could be fixed
too in this PR.

On Mon, Jun 13, 2016 at 10:36 PM Ofir Farchy notifications@github.com
wrote:

@alonisser https://github.com/alonisser You are right, the usage of the
word validation is misleading, what I mean is the submit is enabled on the
actual selection from the autocomplete box, and disables again on any
manual change.

There is a bug I just noticed, when writing a valid name without selecting
from the drop-down, this happens in both the addition\removal inputs and
the bill addition box.

Another bug I saw when implementing (but didn't want to mix is with this
fix) is of the tooltip and input box while selecting the mk\lobyist as
shown here:
[image: image]
https://cloud.githubusercontent.com/assets/3086947/16020513/245ecc8a-31b7-11e6-8ec4-052946fd8732.png
I'll open another issue on this later on.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#695 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABXlcKFGWzsKFMTUYkbL2_7ZoN-gT2fWks5qLbFYgaJpZM4I0k5y
.

[farchy]

An old one, I'll try to fix it too though.

[OriHoch]

I added [WIP] tag to title so we will know it's a Work In Progress and won't merge it

[daonb]

@farchy any progress?