Log each device when scanned, ignore /dev/nbd*, run blkid with timeout#265
Merged
tserong merged 3 commits intoharvester:masterfrom Feb 13, 2026
Merged
Log each device when scanned, ignore /dev/nbd*, run blkid with timeout#265tserong merged 3 commits intoharvester:masterfrom
blkid with timeout#265tserong merged 3 commits intoharvester:masterfrom
Conversation
Related-to: harvester/harvester#9721 Signed-off-by: Tim Serong <tserong@suse.com>
Related-to: harvester/harvester#9721 Signed-off-by: Tim Serong <tserong@suse.com>
Related-to: harvester/harvester#9721 Signed-off-by: Tim Serong <tserong@suse.com>
Vicente-Cheng
approved these changes
Feb 13, 2026
Collaborator
Vicente-Cheng
left a comment
There was a problem hiding this comment.
thanks for the enhancement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
NDM scans every every possible block device under
/sys/block, except for/dev/loop. This can cause trouble if there's some weird device that can't be read, e.g./dev/nbd0which could be connected when using ceph for external storage.Solution:
/dev/nbd*devices (we know we never want to manage those)blkidwith a timeout, so we don't get stuck if we hit some other weird device that's wedged somehowNote: in the original issue I wrote that we should "Limit the disks we scan to only block devices that NDM can reasonably work with", but all I've done here is remove nbd devices. Another approach would be to explicitly only allow
sd*,nvme*,dm-*, and ... what else? I don't actually know what a complete list of allowed devices should look like, so I thought it was safer to just eliminate the one that we know we've had trouble with in the past, and not skip anything else. We can always re-visit this later and add more exclusions (or flip it to the style of an "allow list").Related Issue:
harvester/harvester#9721
Test plan:
TBD