This repository was archived by the owner on Sep 5, 2024. It is now read-only.
Replace charcol that is only supported in neovim 0.7#336
Open
firstmover wants to merge 1 commit intohadronized:masterfrom
Open
Replace charcol that is only supported in neovim 0.7#336firstmover wants to merge 1 commit intohadronized:masterfrom
firstmover wants to merge 1 commit intohadronized:masterfrom
Conversation
Contributor
|
No, this will not pass the test cases in #315. I'v tried local cur_col
if vim.fn.exists('*charcol') == 1 then
cur_col = vim.fn.charcol('.')
else
cur_col = vim.fn.strwidth(vim.api.nvim_get_current_line():sub(1, vim.fn.col('.')))
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit replaces Neovim's built-in function charcol with functions that is available >= 0.5.
charcoal Neovim built-in function is introduced in Neovim 0.7 (see neovim/neovim@6ab7168). The get_window_context function in hop.nvim will raise function not found error when the Neovim version is below 0.7.
This commit partially reverts the 6ed29f1 commit without breaking it.