Adds new integration [matt-richardson/home-assistant-bus-minder]#6691
Conversation
|
Thank you for submitting your repository to HACS (Home Assistant Community Store). Your submission is in the review queue: You can view the current queue here. Pull requests are processed in the order they were created, oldest first. What to avoid during review:
If you need to make changes: About draft pull requests: What happens next:
|
frenck
left a comment
There was a problem hiding this comment.
Hi @matt-richardson, thanks for the submission! 👋
This needs a LICENSE file (or LICENSE.md) at the repository root before it can be added to the HACS default catalog. That's a required item per the publishing docs (https://hacs.xyz/docs/publish/start). Without one, users have no granted rights to redistribute or modify the integration.
Please pick a license (MIT, Apache 2.0, GPL, etc.), commit the LICENSE file to the repo root, cut a new release that includes it, and re-request review (or open a fresh PR if this one ends up closed in the meantime).
../Frenck
Blogging my personal ramblings at frenck.dev
Good call - surprised I missed those. (actually, checking the docs, it doesn't seem to be declared as a requirement yet, though i can see it's definitely wise, and there's work in progress (docs and a validator) to make it so). I've added a license to this repo, and to my other 2 plugins 👍 |
frenck
left a comment
There was a problem hiding this comment.
Hi @matt-richardson, thanks for adding the LICENSE and getting this updated! 👋
One non-blocking note for later: manifest.json lists aiohttp>=3.9 under requirements, but aiohttp ships with Home Assistant core, so you can drop it from the list.
Approving and merging now.
../Frenck
Blogging my personal ramblings at frenck.dev|
Congratulations! Your repository has been added to HACS 🎉 Your repository has been approved: Resources: Thank you for contributing to the Home Assistant community! 🎉 |
…s#6691) Add home-assistant-bus-minder integration Co-authored-by: Franck Nijhof <git@frenck.dev>
Checklist
Links
Link to current release: https://github.com/matt-richardson/home-assistant-bus-minder/releases/tag/v1.1.0
Link to successful HACS action (without the
ignorekey): https://github.com/matt-richardson/home-assistant-bus-minder/actions/runs/23886541852/job/69650444513Link to successful hassfest action (if integration): https://github.com/matt-richardson/home-assistant-bus-minder/actions/runs/23886541852/job/6965044449