Skip to content

Adding YSWS Review and Guardians of Integrity Tables, and Dashboards#84

Open
vandorena wants to merge 69 commits into
hackclub:platformfrom
vandorena:review_pt2
Open

Adding YSWS Review and Guardians of Integrity Tables, and Dashboards#84
vandorena wants to merge 69 commits into
hackclub:platformfrom
vandorena:review_pt2

Conversation

@vandorena
Copy link
Copy Markdown
Contributor

@vandorena vandorena commented May 13, 2026

Adds Review Pages

Still TODO: Commit Graph + Ship Cert Integration + Airtable Sync

YSWS.Review.1.-.Stardance.-.Google.Chrome.2026-05-20.15-29-34.mp4

Comment thread db/migrate/20260513191303_make_ysws_reviews_reviewer_nullable.rb Outdated
@vandorena
Copy link
Copy Markdown
Contributor Author

YSWS.Review.4.-.Stardance.-.Google.Chrome.2026-05-14.11-48-10.mp4

What it's looking like so far

vandorena and others added 6 commits May 21, 2026 12:16
Updated references from NASA mission patch to Artemis II mission patch throughout the landing page.
@vandorena
Copy link
Copy Markdown
Contributor Author

Brakeman Failing isn't due to anything I've touched.

@vandorena vandorena requested a review from Copilot May 21, 2026 17:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 47 out of 52 changed files in this pull request and generated 12 comments.

Comments suppressed due to low confidence (2)

db/migrate/20260512000003_add_devlog_review_id_to_post_devlogs.rb:1

  • devlog_reviews already has post_devlog_id (i.e., the review points to the devlog). Adding post_devlogs.devlog_review_id plus an FK back to devlog_reviews creates a redundant/cyclic relationship that can easily drift or block deletes (FK prevents deleting a devlog_review if any post_devlog still points at it). Pick a single direction: either (a) keep devlog_reviews.post_devlog_id and remove post_devlogs.devlog_review_id + its FK migrations, or (b) remove post_devlog_id from devlog_reviews and make Post::Devlog belongs_to :devlog_review.
    db/migrate/20260514191951_add_status_to_devlog_reviews.rb:1
  • The model declares status as an enum with default :pending, but this migration allows NULLs and does not set a DB default. That can lead to status = NULL rows (e.g., legacy data/backfills/SQL inserts) that don't behave like pending. Consider setting default: \"pending\" and null: false, and backfilling existing rows before applying the constraint.

Comment thread app/models/post/devlog.rb
Comment thread app/models/devlog_review.rb
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/services/admin/review_platform_service.rb
Comment thread app/javascript/controllers/devlog_review_controller.js Outdated
Comment thread app/javascript/controllers/review_sidebar_controller.js
Comment thread app/javascript/controllers/review_sidebar_controller.js Outdated
Comment thread app/javascript/controllers/review_sidebar_controller.js Outdated
Comment thread app/models/devlog_review.rb
@vandorena vandorena changed the title Draft: Adding YSWS Review and Guardians of Integrity Tables, and Dashboards Adding YSWS Review and Guardians of Integrity Tables, and Dashboards May 21, 2026
@vandorena vandorena requested a review from Copilot May 21, 2026 17:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 14 comments.

Comment thread db/schema.rb
Comment thread db/schema.rb
Comment thread db/schema.rb
Comment thread db/schema.rb
Comment thread db/schema.rb
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/services/admin/review_platform_service.rb
Comment thread app/javascript/controllers/review_sidebar_controller.js
Comment thread app/assets/stylesheets/pages/admin/_ysws_reviews.scss
Comment thread app/models/devlog_review.rb
@vandorena vandorena requested a review from Copilot May 21, 2026 18:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 19 comments.

Comment thread app/views/admin/reviews/show.html.erb Outdated
Comment thread app/models/post/devlog.rb
Comment thread app/javascript/controllers/devlog_review_controller.js
Comment thread app/javascript/controllers/devlog_review_controller.js
Comment thread app/controllers/admin/devlog_reviews_controller.rb Outdated
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/models/devlog_review.rb
Comment thread app/models/devlog_review.rb
Comment thread app/models/devlog_review.rb
Comment thread app/models/devlog_review.rb
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 32 out of 32 changed files in this pull request and generated 8 comments.

disable_ddl_transaction!

def change
add_reference :post_devlogs, :devlog_review, null: true, index: { algorithm: :concurrently }
Comment thread app/views/admin/reviews/show.html.erb
Comment thread app/javascript/controllers/github_calendar_controller.js
Comment thread app/javascript/controllers/devlog_review_controller.js Outdated
Comment thread app/controllers/admin/devlog_reviews_controller.rb Outdated
Comment thread app/models/devlog_review.rb
Comment thread app/models/devlog_review.rb
Comment thread app/views/admin/reviews/show.html.erb
vandorena and others added 3 commits May 21, 2026 14:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vandorena vandorena requested a review from Copilot May 21, 2026 19:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 10 comments.

Comments suppressed due to low confidence (1)

db/schema.rb:1

  • This changes an existing FK to validate: false, which means the constraint may remain unvalidated indefinitely and can hide referential-integrity problems in production. If this is intentional for a zero-downtime rollout, follow up with a dedicated validate_foreign_key migration (similar to what you did for post_devlogs.devlog_review_id) to ensure the FK is eventually validated.

Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/views/admin/reviews/show.html.erb
Comment thread app/helpers/admin/reviews_helper.rb
Comment thread app/javascript/controllers/review_sidebar_controller.js
Comment thread app/models/devlog_review.rb
Comment thread db/migrate/20260521190404_add_status_constraint_to_devlog_reviews.rb Outdated
Comment thread app/services/admin/review_platform_service.rb
Comment thread app/javascript/controllers/github_calendar_controller.js Outdated
Comment thread app/controllers/admin/devlog_reviews_controller.rb
vandorena and others added 2 commits May 21, 2026 15:26
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants