Adding YSWS Review and Guardians of Integrity Tables, and Dashboards#84
Open
vandorena wants to merge 69 commits into
Open
Adding YSWS Review and Guardians of Integrity Tables, and Dashboards#84vandorena wants to merge 69 commits into
vandorena wants to merge 69 commits into
Conversation
fix(landing): blahaj -> blåhaj to satisfy the swedes & pedantic
Ysws review
NeonGamerBot-QK
suggested changes
May 14, 2026
Contributor
Author
YSWS.Review.4.-.Stardance.-.Google.Chrome.2026-05-14.11-48-10.mp4What it's looking like so far |
fix(edu): replace artemis patch image with misc patches image
Updated references from NASA mission patch to Artemis II mission patch throughout the landing page.
Contributor
Author
|
Brakeman Failing isn't due to anything I've touched. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 47 out of 52 changed files in this pull request and generated 12 comments.
Comments suppressed due to low confidence (2)
db/migrate/20260512000003_add_devlog_review_id_to_post_devlogs.rb:1
devlog_reviewsalready haspost_devlog_id(i.e., the review points to the devlog). Addingpost_devlogs.devlog_review_idplus an FK back todevlog_reviewscreates a redundant/cyclic relationship that can easily drift or block deletes (FK prevents deleting adevlog_reviewif anypost_devlogstill points at it). Pick a single direction: either (a) keepdevlog_reviews.post_devlog_idand removepost_devlogs.devlog_review_id+ its FK migrations, or (b) removepost_devlog_idfromdevlog_reviewsand makePost::Devlogbelongs_to :devlog_review.
db/migrate/20260514191951_add_status_to_devlog_reviews.rb:1- The model declares
statusas an enum with default:pending, but this migration allows NULLs and does not set a DB default. That can lead tostatus = NULLrows (e.g., legacy data/backfills/SQL inserts) that don't behave likepending. Consider settingdefault: \"pending\"andnull: false, and backfilling existing rows before applying the constraint.
Comment out console log statements for cleaner output.
| disable_ddl_transaction! | ||
|
|
||
| def change | ||
| add_reference :post_devlogs, :devlog_review, null: true, index: { algorithm: :concurrently } |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 35 out of 35 changed files in this pull request and generated 10 comments.
Comments suppressed due to low confidence (1)
db/schema.rb:1
- This changes an existing FK to
validate: false, which means the constraint may remain unvalidated indefinitely and can hide referential-integrity problems in production. If this is intentional for a zero-downtime rollout, follow up with a dedicatedvalidate_foreign_keymigration (similar to what you did forpost_devlogs.devlog_review_id) to ensure the FK is eventually validated.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Review Pages
Still TODO: Commit Graph + Ship Cert Integration + Airtable Sync
YSWS.Review.1.-.Stardance.-.Google.Chrome.2026-05-20.15-29-34.mp4