Fix badges for dotted project names - #1526
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR fixes project badge routing for repository names containing dots by disabling Rails format parsing on the wildcard route.
Confidence Score: 5/5The PR appears safe to merge, with a focused route correction and regression coverage for the reported failure. The route now preserves dotted wildcard values, and the new request spec verifies that the full owner/repository path resolves through its mapping to a valid shields.io redirect. Important Files Changed
Reviews (1): Last reviewed commit: "Fix badges for dotted project names" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Badge URLs for projects whose repository names contain dots return
Project not found. Rails interprets the final portion after the dot as a response format, sopimlico/pimlico.devreaches the controller as projectpimlico/pimlicowith formatdev.Fixes #1488.
Describe your changes
Screenshots / Media
N/A