Skip to content

Search display name overrides in user fuzzy search - #1519

Merged
skyfallwastaken merged 3 commits into
mainfrom
fix/fuzzy-search-display-name-overrides
Aug 4, 2026
Merged

Search display name overrides in user fuzzy search#1519
skyfallwastaken merged 3 commits into
mainfrom
fix/fuzzy-search-display-name-overrides

Conversation

@skyfallwastaken

@skyfallwastaken skyfallwastaken commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary of the problem

User fuzzy search did not consider custom display name overrides, so searching for the name shown in the UI could fail to find the corresponding user.

Describe your changes

  • Include display_name_override in fuzzy-search candidate selection.
  • Rank exact, prefix, and substring display-name matches using the same tiers as other username fields.
  • Add regression coverage for case-insensitive exact and substring searches.

Screenshots / Media

No visual changes.

Copilot AI review requested due to automatic review settings August 4, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR makes display-name overrides searchable through the existing ranked fuzzy-search flow and fixes the previously reported unindexed substring scan.

  • Adds display-name overrides to candidate selection and exact, prefix, and substring ranking.
  • Adds a concurrent GIN trigram index for display-name substring searches.
  • Adds regression coverage for case-insensitive exact and substring matches.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
app/models/concerns/user_fuzzy_search.rb Adds display-name override candidate matching and ranking consistently with existing searchable username fields.
db/migrate/20260804184518_add_trgm_index_to_users_display_name_override.rb Adds the appropriate concurrent GIN trigram index for the new case-insensitive substring predicate.
db/schema.rb Records the new migration version and display-name trigram index.
test/models/concerns/user_fuzzy_search_test.rb Covers case-insensitive exact and substring searches against display-name overrides.

Reviews (3): Last reviewed commit: "Index display name overrides for fuzzy s..." | Re-trigger Greptile

Comment thread app/models/concerns/user_fuzzy_search.rb
@skyfallwastaken
skyfallwastaken enabled auto-merge (squash) August 4, 2026 18:51
@skyfallwastaken
skyfallwastaken merged commit fa383cc into main Aug 4, 2026
19 checks passed
@skyfallwastaken
skyfallwastaken deleted the fix/fuzzy-search-display-name-overrides branch August 4, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants