Skip to content

Fix tag release packaging and unsigned macOS verification#14

Merged
haaaashimi merged 2 commits into
mainfrom
codex/fix-release-ci
Jun 8, 2026
Merged

Fix tag release packaging and unsigned macOS verification#14
haaaashimi merged 2 commits into
mainfrom
codex/fix-release-ci

Conversation

@haaaashimi

Copy link
Copy Markdown
Owner

Root cause

The v1.3.0 release run packaged the static package.json version 1.0.0, causing electron-builder to target the existing v1.0.0 release. The matrix build also implicitly published artifacts before the dedicated publish job. On macOS, CI has no Developer ID certificate, but the workflow still ran strict signature verification against the unsigned app bundle.

Changes

  • derive the packaged app version from GITHUB_REF_NAME
  • pass --publish never to electron-builder build scripts so the final publish job exclusively owns publishing
  • verify bundled macOS resources without strict app-signature checks when the CI build is unsigned

Validation

  • confirmed the failing log reaches a successful DMG build before codesign --verify fails
  • confirmed the release tag is v1.3.0 while electron-builder reports version/tag 1.0.0
  • reviewed the branch diff against main

A tag-triggered release run is still required to fully validate both platform artifacts and publishing.

@haaaashimi haaaashimi marked this pull request as ready for review June 8, 2026 13:07
@haaaashimi haaaashimi merged commit 66024e0 into main Jun 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant