Conversation
The Router no longer imports any Hermes modules directly. All tool listing, calling, validation, and execution is delegated to ClaudeCode.MCP.Backend.Hermes.
Replace the fallback-to-Hermes approach in expand_mcp_module/3 with an explicit compatibility check. Unrecognized modules now raise an ArgumentError instead of silently assuming Hermes compatibility.
Move detection logic from CLI.Command into ClaudeCode.MCP so both Router and Command use a single entry point. Drop Hermes branding from MCP moduledoc.
Remove Hermes.Server.Component dependency from generated tool modules. Tools now use execute/2 with (params, assigns) instead of Hermes frame. Schema generation uses our own field macro and type_to_json_schema/1.
Add input_schema validation to Backend.Anubis (required fields + type checks). Fix router and hermes test assigns to use direct map instead of frame.assigns.
Anubis is checked first in backend_for/1 for subprocess detection. Backend.Hermes tests reduced to compatible?/1 only since the macro no longer generates Hermes-compatible modules.
Both backends now check if their respective library (Anubis.Server or Hermes.Server) is loaded before claiming compatibility. This allows either dep to be absent without errors.
Backend.Anubis only compiles if Anubis.Server is loaded. Backend.Hermes only compiles if Hermes.Server is loaded. backend_for/1 guards with Code.ensure_loaded? before calling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.