bazel: always load java_proto_library from the protobuf repo #12571
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminp
force-pushed
the
proto-loads
branch
from
5b9c78f to
e11cb7c
Compare
The java_proto_library rule in rules_java is deprecated.
benjaminp
force-pushed
the
proto-loads
branch
from
e11cb7c to
a686b55
Compare
ejona86
approved these changes
Dec 23, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
Approving this with the assumption that Bazel 9 is released early in January (like normal, and planned: 2026-01-05), and that we drop Bazel 7 for the next release.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Contributor
Author
|
Thanks! Does that also mean we can kill |
Member
I have been considering it, but I don't think so. Bazel 8 still supports WORKSPACE, even if it is off by default. Our build/example actually doesn't work right now with Bazel 8 without bzlmod, so I'm about to send out a PR to fix it. The BUILD files are all fine, it just needs the proper WORKSPACE, so some users could still be running with it. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The java_proto_library rule in rules_java is deprecated.