Conversation
Pushes to PR-ed branches were triggering test-build twice: once via the push event and once via the matching pull_request event. The duplicate matrix run wasted ~20-35 minutes per push, and the concurrency cancel-in-progress occasionally cancelled one of the two, surfacing the PR as a red cross on the commit. Restrict push to master only; PR development still gets one full run via the pull_request trigger, master keeps push-tested post-merge, and the weekly schedule is unchanged.
The concurrency.group + cancel-in-progress combination was sporadically cancelling package-build runs in the first ~2 seconds, before any job started, even with no second event firing. The build itself is short (~40s) and idempotent, so superseding an in-progress run buys nothing worth a cancelled status on the commit. Match pr-review.yml, which has no concurrency block and is never spuriously cancelled. test-build keeps its concurrency block because it runs long enough that supersession on new commits actually matters.
|
📦 Built packages are ready! Download here. |
mika
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid GitHub actions auto-cancellations, hopefully. Which GitHub now treats as errors, at least in the per-commit view.
Claude explanation which is partially wrong: