Refactor SmartInput and AutocompletePopup #176
Conversation
…ncerns - Decouple SmartInput from File I/O by moving file expansion logic to TextualApp. - SmartInput.Submitted message now carries a CompletionResult instead of a string. - Delegate key handling (up/down/enter/tab/escape) from SmartInput to AutocompletePopup using a new `handle_key` method. - Update TextualApp to use FileLoader to expand content upon submission.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ncerns - Decouple SmartInput from File I/O by moving file expansion logic to TextualApp. - SmartInput.Submitted message now carries a CompletionResult instead of a string. - Delegate key handling (up/down/enter/tab/escape) from SmartInput to AutocompletePopup using a new `handle_key` method. - Update TextualApp to use FileLoader to expand content upon submission. - Remove backward compatibility for `Submitted.value`.
gregorriegler
deleted the
refactor-smart-input-autocomplete-3963878248178462808
branch
This change refactors
SmartInputandAutocompletePopupto adhere to the Principle of Least Knowledge and improve separation of concerns.Key changes:
DiskFileLoaderandXmlFormattingFileLoaderdependencies.SmartInputno longer expands file content; it submits aCompletionResultcontaining the raw text and file references.FileLoaderwhen handling theSmartInput.Submittedevent. This keeps I/O logic at the application root rather than deep in a UI widget.handle_keyto encapsulate navigation logic (up, down, accept, close).SmartInputnow delegates these key events to the popup instead of manipulating the popup's state directly.These changes simplify the API of
SmartInputand ensureAutocompletePopupis more self-contained. All tests passed.PR created automatically by Jules for task 3963878248178462808 started by @gregorriegler