-
Notifications
You must be signed in to change notification settings - Fork 124
Upcoming Release Changes #7425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upcoming Release Changes #7425
Conversation
Summary of ChangesHello @theguild-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated release PR, generated by the Changesets GitHub action, to facilitate the publication of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
25cd4be to
d653d2a
Compare
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7425.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This automated release PR correctly updates the version and changelog. I've also reviewed the implementation of the new usage info API being released. While the logic is sound, I found some opportunities to improve maintainability by reducing code duplication:
- In
packages/services/api/src/modules/commerce/resolvers/Organization.ts, the rate limit check logic is duplicated in therateLimitandisMonthlyOperationsLimitExceededresolvers. This could be refactored into a helper function. - Error handling for
usageEstimationis repeated inpackages/services/api/src/modules/commerce/resolvers/Organization.tsandpackages/services/api/src/modules/commerce/resolvers/Query/usageEstimation.ts. This could be moved into theUsageEstimationProviderto centralize the logic.
Since these files are not part of the PR's diff, I'm including this feedback here for future consideration.
💻 Website PreviewThe latest changes are available as preview in: https://pr-7425.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
d653d2a to
bf4c0db
Compare
bf4c0db to
3777953
Compare
3777953 to
02cbe56
Compare
02cbe56 to
ca2f67b
Compare
ca2f67b to
87817e9
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
#7423
a71cd2bThanks @n1ru4l! - Bump minio docker images to latest stable version.
#7418
444c0ccThanks @jdolle! - Add usage info to public API. This usage data can
be requested using the operation: