add policy test for eslint-disable-next-line #7403
Conversation
Summary of ChangesHello @jdolle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new test to validate the behavior of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a test to verify that eslint-disable-next-line comments are respected by the schema policy linter. The test itself is well-structured, but I've found a small inconsistency in the test data that should be addressed for better maintainability and to prevent potential issues with other linting rules.
| # eslint-disable-next-line | ||
| type Query { foo: String! } | ||
| `, | ||
| schema: 'type Query { foo: String! }', |
There was a problem hiding this comment.
The schema property should be consistent with the source property (excluding ESLint comments). The source includes a description for the Query type, but the schema string does not. While this might not affect this specific test, it's a good practice to keep them aligned to avoid potential issues with other rules that might rely on descriptions or other parts of the schema's AST.
| schema: 'type Query { foo: String! }', | |
| schema: '"""The root query type""" type Query { foo: String! }', |
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7403.hive-storybook.pages.dev |
💻 Website PreviewThe latest changes are available as preview in: https://pr-7403.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
1 participant
Background
We received a report that our linter is not using the "eslint-disable-next-line" feature.
Description
This adds a test to verify the behavior.