add mention of caption_entities to filter-queries.md#1212
add mention of caption_entities to filter-queries.md#1212mordv wants to merge 8 commits intogrammyjs:mainfrom
Conversation
|
Why did you add this specific filter query and not one of the 1395 filter queries that are not mentioned on the page? |
|
Same reason others were added - picked randomly.
|
KnorpelSenf
left a comment
There was a problem hiding this comment.
Sorry for the insane delay, I really don't have enough time for OSS recently. This can still be merged, but I don't fully agree yet:
| bot.on("message:caption_entities:url"); // captions containing a URL | ||
| bot.on("message:entities:code"); // messages containing a code snippet |
There was a problem hiding this comment.
How about this instead?
| bot.on("message:caption_entities:url"); // captions containing a URL | |
| bot.on("message:entities:code"); // messages containing a code snippet | |
| bot.on("message:caption_entities:code"); // captions containing a code snippet |
| | `"message"` | `"message"` | `undefined` | `undefined` | | ||
| | `"message:entities"` | `"message"` | `"entities"` | `undefined` | | ||
| | `"message:entities:mention"` | `"message"` | `"entities"` | `"mention"` | | ||
| | `"message:caption_entities:url"` | `"message"` | `"caption_entities"` | `"url"` | |
There was a problem hiding this comment.
This is inconsistent with the other rows. The point here is to show how a single query is built up in three parts. Adding a second random query is confusing.
Let's revert.
| | `"message:caption_entities:url"` | `"message"` | `"caption_entities"` | `"url"` | |
|
Closing due to inactivity. |
No description provided.