Add Storybook coverage and fix mobile carousel hydration#148
Open
encryptedDegen wants to merge 2 commits into
Open
Add Storybook coverage and fix mobile carousel hydration#148encryptedDegen wants to merge 2 commits into
encryptedDegen wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
I reviewed the Storybook setup, component inventory coverage, and the mobile carousel hydration change. I did not find any blocking PR-introduced issues.\n\nVerification performed: component inventory matches the intended tracked component files; lint passes; Storybook builds successfully. Typecheck currently fails in an untouched PremiumPriceControls StaticImageData typing issue, and I reproduced the same failure on main, so I am not treating it as a regression from this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
bun run typecheckbun run lint(passes with one pre-existing.opencodewarning)bun run build-storybookCreated with Open-Inspect