maxInterStageShaderVariables: decrement max fragment input outputs per fragment input built-in#4539
Merged
ErichDonGubler merged 3 commits intogpuweb:mainfrom Dec 22, 2025
Conversation
maxInterStageShaderVariables: decrement max fragment input outputs per fragment input built-in
dneto0
approved these changes
Dec 22, 2025
Contributor
dneto0
left a comment
There was a problem hiding this comment.
Nice catch. LGTM.
This might explain some failures in Chrome/Dawn too.
Contributor
|
FYI: Run |
…tPipelineDescriptor`
…in as a separate deduction
…ment input deduction calc.
b907cca to
5587128
Compare
Member
Author
|
NOTE: Per @kainino0x's question about coverage (see #4538 (comment)), I'm adding more coverage for the rest of the fragment input built-ins with d00cd2c. @dneto0: The re-review should be fast! 🙏🏻 |
Member
Author
|
Hmm…with the CI failures, I'm not sure how to handle this immediately. I'd rather lock in the reviewed-and-passing stuff I initially added, and break out the fix for gpuweb/gpuweb#5403 separately. I've rolled back to 5587128, and will file a separate issue/PR pair. |
d00cd2c to
5587128
Compare
This was referenced Dec 22, 2025
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #4538
Recommended review experience is commit-by-commit.
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.maxInterStageShaderVariablesshould be decremented for _each_ fragment input built-in, not just once #4538 ).Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.