Conversation
Replace antd Tag with core-ui StatusDot (dot + text), mapping event types to StatusType semantic colors.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request documents and adopts the core-ui tag and status components (StatusDot, ThemeTag, TextAttribute) across several columns and views, replacing custom-styled elements. Feedback on the changes highlights two issues: changing a column's span to a fixed width in the models table breaks the 24-unit grid layout and leaves dead code, and adding gap-8 to the parent container of TextAttribute causes double spacing since TextAttribute already manages its own margin.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| key: 'created_at', | ||
| sorter: tableSorter(5), | ||
| span: spans.createTime, | ||
| width: 180, |
There was a problem hiding this comment.
Changing the span to a fixed width of 180 breaks the 24-unit grid layout of SealTable (where column spans must sum to 24). It also leaves createTime as dead code in SPANS_DEFAULT and SPANS_WITH_PLUGIN. Revert this back to span: spans.createTime to maintain grid alignment.
| width: 180, | |
| span: spans.createTime, |
| sorter: tableSorter(1), | ||
| render: (text: string, record: ListItem) => ( | ||
| <span className="flex items-center"> | ||
| <span className="flex items-center gap-8"> |
There was a problem hiding this comment.
According to the documentation in CLAUDE.md, TextAttribute manages its own leading margin. Adding gap-8 to the parent span will result in double spacing when record.is_custom is true. Remove gap-8 from the parent container to let TextAttribute handle its own spacing.
| <span className="flex items-center gap-8"> | |
| <span className="flex items-center"> |
There was a problem hiding this comment.
Pull request overview
Refactors tag/status rendering across several UI surfaces to use the standardized @gpustack/core-ui tag/status components (e.g., StatusDot, ThemeTag, TextAttribute) and updates contributor guidance accordingly.
Changes:
- Replaces the Usage → Events tab’s antd
Tag-based event-type indicator withStatusDotusing semantic status values. - Standardizes tag styling/usage in API keys and GPU storage type tables by adopting
TextAttribute/ThemeTag. - Updates
CLAUDE.mdwith clearer guidance on choosing between tag/status indicator components.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pages/usage/events-tab/index.tsx | Switches event-type display from color tags to semantic StatusDot statuses. |
| src/pages/llmodels/hooks/use-models-columns.tsx | Adjusts the create-time column sizing metadata (span → fixed width). |
| src/pages/gpu-service/storage-types/hooks/use-storage-type-columns.tsx | Simplifies ThemeTag usage by removing redundant inline sizing styles. |
| src/pages/api-keys/hooks/use-keys-columns.tsx | Replaces custom/antd tag styles with TextAttribute and ThemeTag. |
| src/pages/_components/model-tag.tsx | Tweaks model tag styling to use a transparent background. |
| CLAUDE.md | Documents the intended tag/status component choices and semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| title: intl.formatMessage({ id: 'common.table.createTime' }), | ||
| dataIndex: 'created_at', | ||
| key: 'created_at', | ||
| sorter: tableSorter(5), | ||
| span: spans.createTime, | ||
| width: 180, |
No description provided.