Skip to content

fix: handle negative offset cases #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krishnamd-jkp merged 1 commit into from
Jun 19, 2026
Merged

fix: handle negative offset cases #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions testbench/grpc_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,6 +591,8 @@ def ReadObject(self, request, context):
meta = blob.metadata
size = storage_pb2.ServiceConstants.Values.MAX_READ_CHUNK_BYTES
start = request.read_offset
if start < 0:
start = max(0, len(blob.media) + start)
read_end = len(blob.media)
if start > read_end:
return testbench.error.range_not_satisfiable(context)
Expand Down Expand Up @@ -717,6 +719,8 @@ def process_read_range(range):
# A read range corresponds to a unique read_id.
# For the same read_id, it is guaranteed that responses are delivered in increasing offset order.
start = range.read_offset
if start < 0:
start = max(0, len(blob.media) + start)
read_end = len(blob.media)
read_id = range.read_id

Expand Down
Loading