Skip to content

fix(bqjdbc): update metadata values for GEOGRAPHY/JSON/INTERVAL types #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logachev wants to merge 3 commits into
base: main
Choose a base branch
from
+27 −4
Open

fix(bqjdbc): update metadata values for GEOGRAPHY/JSON/INTERVAL types #13223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ccbc6d
fix(bqjdbc): update metadata values for GEOGRAPHY type
logachev May 18, 2026
7aa1ecd
add tests
logachev May 18, 2026
7ba4663
lint
logachev May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-bigquery-jdbc/src/main/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4845,9 +4845,11 @@ private ColumnTypeInfo getColumnTypeInfoForSqlType(StandardSQLTypeName bqType) {
case TIME:
return new ColumnTypeInfo(Types.TIME, "TIME", 15, null, null);
case GEOGRAPHY:
return new ColumnTypeInfo(Types.OTHER, "GEOGRAPHY", null, null, null);
case JSON:
return new ColumnTypeInfo(Types.OTHER, "JSON", null, null, null);
case INTERVAL:
return new ColumnTypeInfo(Types.VARCHAR, "VARCHAR", null, null, null);
return new ColumnTypeInfo(Types.OTHER, "INTERVAL", null, null, null);
case BYTES:
return new ColumnTypeInfo(Types.VARBINARY, "VARBINARY", null, null, null);
case STRUCT:
Expand Down
27 changes: 24 additions & 3 deletions ...query-jdbc/src/test/java/com/google/cloud/bigquery/jdbc/BigQueryDatabaseMetaDataTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,16 +342,37 @@ public void testMapBigQueryTypeToJdbc_ScalarTypes() {
assertEquals(Integer.valueOf(38), infoBigNumeric.decimalDigits);
assertEquals(Integer.valueOf(10), infoBigNumeric.numPrecRadix);

// GEOGRAPHY -> VARCHAR
// GEOGRAPHY -> OTHER
Field fieldGeo =
Field.newBuilder("test_geo", StandardSQLTypeName.GEOGRAPHY)
.setMode(Field.Mode.NULLABLE)
.build();
BigQueryDatabaseMetaData.ColumnTypeInfo infoGeo = dbMetadata.mapBigQueryTypeToJdbc(fieldGeo);
assertEquals(Types.VARCHAR, infoGeo.jdbcType);
assertEquals("VARCHAR", infoGeo.typeName);
assertEquals(Types.OTHER, infoGeo.jdbcType);
assertEquals("GEOGRAPHY", infoGeo.typeName);
assertNull(infoGeo.columnSize);

// JSON -> OTHER
Field fieldJson =
Field.newBuilder("test_json", StandardSQLTypeName.JSON)
.setMode(Field.Mode.NULLABLE)
.build();
BigQueryDatabaseMetaData.ColumnTypeInfo infoJson = dbMetadata.mapBigQueryTypeToJdbc(fieldJson);
assertEquals(Types.OTHER, infoJson.jdbcType);
assertEquals("JSON", infoJson.typeName);
assertNull(infoJson.columnSize);

// INTERVAL -> OTHER
Field fieldInterval =
Field.newBuilder("test_interval", StandardSQLTypeName.INTERVAL)
.setMode(Field.Mode.NULLABLE)
.build();
BigQueryDatabaseMetaData.ColumnTypeInfo infoInterval =
dbMetadata.mapBigQueryTypeToJdbc(fieldInterval);
assertEquals(Types.OTHER, infoInterval.jdbcType);
assertEquals("INTERVAL", infoInterval.typeName);
assertNull(infoInterval.columnSize);

// DATE
Field fieldDate =
Field.newBuilder("test_date", StandardSQLTypeName.DATE)
Expand Down
Loading