fix(bqjdbc): Pass connection ID to DataType class loggers#13197
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the logging infrastructure within the BigQuery JDBC driver to improve context tracking and performance. Key changes include passing logger instances through the coercion and result set layers, enhancing BigQueryJdbcResultSetLogger to include thread IDs and source class names, and adding entry/exit logging in BigQueryJdbcContextProxy. Feedback for BigQueryJdbcContextProxy suggests optimizing the new logging logic by caching class and method names in local variables to reduce overhead on the hot path.
Contributor
keshavdandeva
left a comment
keshavdandeva
left a comment
There was a problem hiding this comment.
We should add some form of test (or update existing ones?) for verifying connectionId propagation
Contributor
Author
|
Added tests |
logachev
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.