test: re-enable and fix timed-out unit tests in PublisherImplTest#13180
test: re-enable and fix timed-out unit tests in PublisherImplTest#13180michaelpri10 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request re-enables the testResumePublish and testPublishThrowExceptionForUnsubmittedOrderingKeyMessage tests in PublisherImplTest.java which were previously disabled. The testResumePublish test was updated to use a fake executor for the publisher service implementation. Review feedback suggests that testPublishThrowExceptionForUnsubmittedOrderingKeyMessage should also be updated to use the same fake executor configuration to ensure consistency and prevent potential timeout issues.
| Publisher publisher = | ||
| getTestPublisherBuilder() |
There was a problem hiding this comment.
The test testResumePublish was updated to include testPublisherServiceImpl.setExecutor(fakeExecutor); to resolve timeout issues. It appears that testPublishThrowExceptionForUnsubmittedOrderingKeyMessage might require a similar configuration to ensure the mock service uses the same fake executor, especially since it is also being re-enabled after previously timing out.
testPublisherServiceImpl.setExecutor(fakeExecutor);
Publisher publisher =
getTestPublisherBuilder()
Fixes #13051